test: disable network-imports test #17835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hi-ogawa
force-pushed
the
fix-drop-network-imports
branch
from
0762ab0
to
d1c9d56
Compare
bluwy
approved these changes
Aug 8, 2024
Bonniemarie216
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Though Node has decided to drop network import feature nodejs/node#53822, the code needed on Vite side to make it work was a one-liner to externalizing
httpimport #15599, so I'm thinking we don't need to revert that part.But, I'm not sure what to do with existing tests. Whether we skip it for specific Node version or completely remove them. For now, I added node v22 check to skip tests.